Map node binaries whenever rvm1:hook
is called and evaluate the fnm_setup_command
dynamically
#5303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
The previous version worked fine when using Capistrano to deploy a new release, but it did not work for other commands, like
cap npm install
orcap puma:start
, as they do not create a release. Therefore, thegit:create_release
was never called, and themap_node_bins
was not invoked.Objectives
Since we need node binaries available to the deploy user when executing any process that runs the application, like puma, delayed_job, and rake tasks, among others, it makes sense to load FNM to use the correct Node version in the same places where Capistrano loads RVM to load the correct Ruby version.
With dynamic loading of the
fnm_setup_command
, we get the correct path when deploying a new release and also when running any other capistrano command that does not deploy a new release.